Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Markup import. Modified get_partial() function which failed on some HTML #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed Markup import. Modified get_partial() function which failed on some HTML #6

wants to merge 2 commits into from

Conversation

eanon
Copy link

@eanon eanon commented May 27, 2023

  • Fixed Markup import.
  • Modified get_partial() function (now relying on lxml) which failed parsing some pieces of HTML (didn't locate the modal body giving a partial that started at beginning of modal window until the end of the html document; ie. ).
  • Added lxml as required dependency in setup.py.
  • Removed any version constraint in requirements.txt of the examples.
    ­
    Feel free to review at your convenience.

@eanon
Fixed Markup import. Modified get_partial() function which failed to …
31328f3 
…parse some pieces of HTML; now relying on lxml. Added lxml as required dependency in setup.py. Removed any version constraint in requirements.txt of examples.
@eanon eanon changed the title Fixed Markup import. Modified get_partial() function which failed to on some HTML Fixed Markup import. Modified get_partial() function which failed on some HTML May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GJayLG GJayLG GJayLG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eanon @GJayLG