Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform tested platforms list into a table #262

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

vitorhcl
Copy link
Contributor

This makes the list more readable

@deajan
Copy link
Owner

deajan commented Mar 13, 2024

Thanks for your time.
Please remove the method column and put "via termux" in the version column of android, that will be much clearer.

@vitorhcl
Copy link
Contributor Author

Thanks for your time. Please remove the method column and put "via termux" in the version column of android, that will be much clearer.

Do you think that both Android and Windows should use the version column for the method? IMO a separate column is much more clearer, we can even rename it to "Notes" and put things like OpenRC and InitV. After all, you decide it.

@deajan
Copy link
Owner

deajan commented Mar 13, 2024

I don't feel like a Method / notes table makes things easier.
Also, systemd, initv and openrc don't have their place in the list.
How about you just remove them completely, and just add two footnotes for android and windows ?

@vitorhcl
Copy link
Contributor Author

I don't feel like a Method / notes table makes things easier.
Also, systemd, initv and openrc don't have their place in the list.
How about you just remove them completely, and just add two footnotes for android and windows ?

I thought of 2 options:

  1. Remove the 2 platforms completely from the table and the methods/notes column and add a note later like the Gentoo + OpenRC mention.
  2. Only remove the methods/notes column and add "*" and "**" and footnotes below the table

What approach do you think is best for me to take?

@deajan
Copy link
Owner

deajan commented Mar 23, 2024

Option 2 sounds good to me ;)
Thank you for your time investment.

@vitorhcl
Copy link
Contributor Author

No problem! So I'm gonna do the 2nd option.

@deajan deajan merged commit 639055b into deajan:master Mar 27, 2024
3 checks passed
@deajan
Copy link
Owner

deajan commented Mar 27, 2024

Thank you Vitor, appreciating.

@vitorhcl vitorhcl deleted the add-tested-platforms-table branch March 30, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants