Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference spec and increase msgbuffer size so log message are … #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Update reference spec and increase msgbuffer size so log message are … #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/logstuff.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ static void InternalLogMail( const char *msgbuffer, unsigned int msglen, int /*f
// a (va_list *) instead to avoid this problem
void LogWithPointer( int loggingTo, const char *format, va_list *arglist )
{
char msgbuffer[1024]; //min 1024!!, but also think of other OSs stack!!
char msgbuffer[32000]; //min 1024!!, but also think of other OSs stack!!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How large do you think this buffer actually needs to be? 32k may represent a significant amount of stack space on some older hardware, so we'd like to not unnecessarily enlarge this more than necessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point, I had to increase this as the BuildCLPrpgram function displayed the log size was 16283 so LogWithPointer failed as it was not going to fit in 1024 bytes. I just set it so it would display the error message. As log messages could be any length. I would suggest that msgbuffer be allocated on the heap instead of the stack to avoid possible overrun errors. I can implement and test to verify functionality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the message were truncated to 1024 chars (rather than overflowing the buffer and crashing as it presumably did), would that have provided enough information to understand the meaning of the build failure?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no information provided on the reason for the build failure. This is the output before I increased the msgbuffer size.

[Feb 26 19:11:55 UTC] Error building cl program on device 2
[Feb 26 19:11:55 UTC] Error code -11, message: Program build failure
[Feb 26 19:11:55 UTC] Build log returned 16263 bytes
Build Log:

unsigned int msglen = 0, sel;
char *buffptr, *obuffptr;
int old_loggingTo = loggingTo;
Expand Down
2 changes: 1 addition & 1 deletion rc5-72/opencl/ocl_common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ bool BuildCLProgram(ocl_context_t *cont, const char* programText, const char *ke
if (status == CL_SUCCESS)
{
//status = clBuildProgram(cont->program, 1, &cont->deviceID, NULL, NULL, NULL);
status = clBuildProgram(cont->program, 1, &cont->deviceID, "-cl-std=CL1.1", NULL, NULL);
status = clBuildProgram(cont->program, 1, &cont->deviceID, "-cl-std=CL1.2", NULL, NULL);
}
if (ocl_diagnose(status, "building cl program", cont) != CL_SUCCESS)
{
Expand Down