PoC - Logging, Authentication, generated clients for IAM, Secrets, Cosmos #8
Conversation
| @@ -0,0 +1,938 @@ | |||
| swagger: '2.0' | |||
There was a problem hiding this comment.
Can we have the spec definitions in an openapi directory? As it's the new name for them.
| }, nil | ||
| } | ||
|
|
||
| func (c *Client) Login(username, password string) (string, error) { |
There was a problem hiding this comment.
Given that we have different login methods (username/password, service account, oidc/saml), in the future either we say uid/password is the default and keep it named Login, then we'll add eg. ServiceLogin, we could also make the arguments more generic instead.
| @@ -0,0 +1,27 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Ideally this would be triggered by go generate
Revert changes in generated code
The underlying `*http.Client` that we provide already sets the header
mrnugget
force-pushed
the
research_swagger
branch
from
d3c7f38
to
61e6f40
Compare
Rebased and pushed. CI now runs and fails due to missing comments. But I have to say, since it's just a proof of concept, I really don't want to merge this as it is 😉 It should rather serve as an example to see what's possible and how it would be possible and what could be done in the future |
This is just a proof-of-concept for several requirements that we're after:
The most important file to look at is
example.orgwhich contains examples forNoteworthy:
PackageOptionsstruct has been manually created inside thedcos/cosmosfolder (which means we are able to manually create helper methods inside the sub-clients)The code is not clean, it's not tested, there is duplication, and it could and should be moved around a little bit, but it allows us to see what's possible :)