Simplify checkArrayTypes, add test.

dchest · Nov 2, 2014 · 1c64578 · 1c64578
1 parent b47750a
commit 1c64578
Show file tree

Hide file tree

Showing 5 changed files with 79 additions and 9 deletions.
diff --git a/nacl-fast.js b/nacl-fast.js
@@ -2148,9 +2148,9 @@ function checkBoxLengths(pk, sk) {
 }
 
 function checkArrayTypes() {
-  var type = {}.toString, t;
-  for (var i = 0; i < arguments.length; i++) {
-     if ((t = type.call(arguments[i])) !== '[object Uint8Array]')
+  var t, i;
+  for (i = 0; i < arguments.length; i++) {
+     if ((t = Object.prototype.toString.call(arguments[i])) !== '[object Uint8Array]')
        throw new TypeError('unexpected type ' + t + ', use Uint8Array');
   }
 }

diff --git a/nacl-fast.min.js b/nacl-fast.min.js
diff --git a/nacl.js b/nacl.js
@@ -935,9 +935,9 @@ function checkBoxLengths(pk, sk) {
 }
 
 function checkArrayTypes() {
-  var type = {}.toString, t;
-  for (var i = 0; i < arguments.length; i++) {
-     if ((t = type.call(arguments[i])) !== '[object Uint8Array]')
+  var t, i;
+  for (i = 0; i < arguments.length; i++) {
+     if ((t = Object.prototype.toString.call(arguments[i])) !== '[object Uint8Array]')
        throw new TypeError('unexpected type ' + t + ', use Uint8Array');
   }
 }