Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional params for requests #38

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Conversation

SebastienGllmt
Copy link
Contributor

As you can see from the EIP-1193 definition, params is allowed to be optional

However, in the WSC code, we accidentally made params a required object. This PR fixes that

@SebastienGllmt SebastienGllmt changed the title Allow optiona params for requests Allow optional params for requests Jan 13, 2024
@SebastienGllmt SebastienGllmt merged commit 061ba93 into main Jan 13, 2024
3 checks passed
@SebastienGllmt SebastienGllmt deleted the allow-optional-params branch January 13, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant