Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more instances of windows.ethereum #33

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

SebastienGllmt
Copy link
Contributor

Phantom intercepts any call to setting window.ethereum to stop them from replacing Phantom. That means we cannot use window.ethereum anywhere in the code and have to keep a reference to the WSC provider otherwise Phantom will get used instead of WSC causing issues

Copy link

@MartinOndejka MartinOndejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicarq nicarq merged commit e7727ce into main Jan 11, 2024
3 checks passed
@nicarq nicarq deleted the window-ethereum-removal branch January 11, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants