Skip to content

Commit

Permalink
Change PR checks trigger strategy: makes sense to run CI when PR is o…
Browse files Browse the repository at this point in the history
…pen, otherwise we can't verify it works and compiles unless we submit review / run locally. Before reviewing it makes sense quite often to see that checks have passed (#150)
  • Loading branch information
gostkin authored Dec 9, 2022
1 parent 9810a78 commit f5f49b1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
name: PR Checks

on:
pull_request_review:
types: [submitted]
push:
branches: [ develop ]
pull_request:
branches: [ develop ]

jobs:
test-and-build:
if: github.event.review && (github.event.review.state == 'approved' || contains(github.event.review.body, '/check'))
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -42,7 +43,6 @@ jobs:
run: |
npm run rust:build-browser
check-warns:
if: github.event.review && (github.event.review.state == 'approved' || contains(github.event.review.body, '/check'))
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ rust/core/Cargo.lock
rust/wasm/target/**
rust/wasm/Cargo.lock
rust/json-gen-split/target/**
tools/metadata-cddl-checker/Cargo.lock

0 comments on commit f5f49b1

Please sign in to comment.