Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell support: workflow, config + make it fix typos #174

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link

See https://github.com/codespell-project/codespell for more info about the tool.

I am on a quest to codespell any project "I touch", so here I am -- feel welcome to close this PR and cherish the typos ;)

Note that some typos were found in the code so might affect (fix?) the operation. Please review with care.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'occure only once' 'occur only once'",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
…ut ignore fail

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w | :",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w -i 3 -C 2",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@@ -19,7 +19,7 @@ class ServerUtils {
var exponentHex = exponentRaw.stream.hexDump(exponentStart, exponentEnd);
var exponent = Hex.decode(exponentHex);

return { success: true, msg: { moduls: modulus, exponent: exponent } };
return { success: true, msg: { modulus: modulus, exponent: exponent } };
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. here is functional change. I found no other mentioning of getRSAModulusAndExponent here or entire github -- so may be it just was never used and could be just removed altogether?

@@ -65,7 +65,7 @@
</svg></a>
</td>
</tr>
<tr ng-repeat-end ng-if="binding.epxanded">
<tr ng-repeat-end ng-if="binding.expanded">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is another possibly functionality effecting change - but my guess since was incorrectly typed everywhere -- should be fine?

@manonthegithub
Copy link
Collaborator

Thanks for contributing. Looks like a useful tool for us, but I don't think it is a good idea to use a python tool in a project which does not use any python. There must be similar tools which could be employed for spellchecking and correction injs as well. @holycrab13 WDYT? do you know one?

@yarikoptic
Copy link
Author

I use tools written in other languages all the time, but I could see some rationale behind such desire for local needs (for CI -- doesn't really matter). FWIW I am aware of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants