Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test name collision (test_writeArrayToRaster) #669

Merged

Conversation

garlic-os
Copy link
Contributor

@garlic-os garlic-os commented Jul 11, 2024

Description

This change renames the writeArrayToRaster series of tests so that none of them override each other by having the same name. The test that wasn't running had a small error that I assume was a typo, and it has been corrected.

Aside: I found this error by running ruff on the project. I did not add tests to ensure a similar problem won't occur again because #650 may already provide a comprehensive solution.

Motivation and Context

test_util.py has two functions named test_writeArrayToRaster_3. Because of the way Python works, the first function was being erased and replaced with the second one, causing it to never run.

How Has This Been Tested?

This change does not break any tests. The test that was re-enabled passes too.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Renamed the writeArrayToRaster series of tests so that none are overridden by any of the others by having the same name.
@garlic-os garlic-os marked this pull request as ready for review July 11, 2024 23:44
@garlic-os garlic-os mentioned this pull request Jul 15, 2024
8 tasks
@jlmaurer jlmaurer merged commit 32697d2 into dbekaert:dev Jul 24, 2024
2 of 6 checks passed
@garlic-os garlic-os deleted the fix-name-collision-test_writeArrayToRaster branch July 24, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants