-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HRRR model levels #570
HRRR model levels #570
Conversation
Thanks Brett, this looks already much better based on your figure. One of the test seems to have an issue with the definition of the layers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I updated the NotImplementedError
message on pressure levels to help me remember in the future why we aren't using them.
@@ -321,39 +308,24 @@ def _load_pressure_level(self, filename, *args, **kwargs): | |||
self._t = t | |||
self._q = q | |||
|
|||
geo_hgt = z / self._g0 | |||
geo_hgt = (z / self._g0).transpose(1, 2, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlmaurer here we transpose the geo_hgt, which then propagates to the z and p
tools/RAiDER/losreader.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you don't specify height levels, then all the model layers will be used. the top of the model layer (ht) is by definition = high_ht at the top. So nothing is calculated and then the stacking crashes. It's a very tiny contribution to the integral.
@cmarshak any idea why the GUNW test could be failing? It writes the first delay successfully but then seems to kill itself during the next datetime:
It should continue with, e.g., But instead just stops and returns:
Maybe a memory issue on circleci? I can't reproduce it locally, and a main change here was to use the |
I would run the test on a linux server via |
Thanks yeah I think it has to be something weird with the memory. If I just run with HRRR (and not GMAO) it works. |
Use the native model levels rather than the pressure levels in order to cover a more complete height of the troposphere.
Closes #568