CB-5775 refactor: make default group text aligned with other tabs #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnaumov
requested changes
Nov 8, 2024
| @@ -55,22 +55,18 @@ export const GrantedUsers: TabContainerPanelComponent<ITeamFormProps> = observer | |||
|
|
|||
| if (isDefaultTeam) { | |||
| return ( | |||
| <Container className={s(styles, { box: true })} parent gap vertical> | |||
| <Group className={s(styles, { placeholderBox: true })} keepSize large> | |||
| <TextPlaceholder>{translate('plugin_authentication_administration_team_default_users_tooltip')}</TextPlaceholder> | |||
There was a problem hiding this comment.
its probably better to keep TextPlaceholder component as if we would like to make changes to all placeholders in the app, we cant do it if we use Group
devnaumov
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-11-08.at.11.51.54.mov