Cb 5584 provide more information in the debug log for auditing #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in global preferences for showing additional logs
…in global preferences for showing additional logs
serge-rider
requested changes
Nov 8, 2024
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/server/graphql/GraphQLLoggerUtil.java
Outdated
Show resolved
Hide resolved
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/server/graphql/GraphQLLoggerUtil.java
Outdated
Show resolved
Hide resolved
| public enum GraphQLProhibitedVariables { | ||
|
|
||
|
|
||
| PASSWORD("password"), |
There was a problem hiding this comment.
It don't think that global enum will work. We need some explicit annotations for parameters which we do not want to log (for example as comments).
However we need to move log invocation into WebExecutionStrategy to get information about GQL endpoint.
If this is too complicated then we can keep it as is for now. In this case add "credentials" and "username" too.
However I don't understand why we need enum but simple Set
There was a problem hiding this comment.
let's leave Set for now, added additional parameters, let's start a task on improve with annotations, need more time for realization
…ug-log-for-auditing
…ug-log-for-auditing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.