Skip to content

Commit

Permalink
docs: add mention to ngaox twitter image alt issue (#347)
Browse files Browse the repository at this point in the history
  • Loading branch information
davidlj95 authored Feb 22, 2024
1 parent 69c3218 commit d54cdff
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions projects/ngx-meta/docs/content/why/comparison.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ It is certainly a better option than installing a poorly maintained library. But

- `#!html <meta name="canonical">` is set by `@avivharuzi/ngx-seo`. However, **that metadata name is not standard**. `#!html <link rel="canonical">` is the HTML spec standard way of specifying canonical URLs.
- `#!html <meta name="twitter:url">` is set by `@avivharuzi/ngx-seo`. However, **that metadata name is not specified in Twitter Cards markup reference**
- `#!html <meta name="twitter:image:alt">` is set by `@ngaox/seo` [**with `property` attribute instead of `name` attribute**](https://github.com/ngaox/ngaox/blob/v5.0.0/packages/seo/src/lib/seo.service.ts#L105). [A PR has been opened to fix it](https://github.com/ngaox/ngaox/pull/256)
- `#!html <meta property="og:author">` and `#!html <meta property="og:publisher">` are supported by `@ngx-meta/core`. But those are not valid Open Graph elements. In any case, they would be `#!html <meta property="og:article:author|publisher">`

## Excluded candidates
Expand Down

0 comments on commit d54cdff

Please sign in to comment.