Bump to rom v4 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've fixed the travis build but I had to disable running simplecov on travis since it was running into permission errors I'm not sure exactly best fix for as I think it's docker related not travis. I also updated FactoryGirl to FactoryBot to fix the deprecation warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't run the specs for this yet, but it seems to be working okay so far in my application.
When I did try to run the specs on the master branch they failed for me though, and ended up deleting all my dynamodb local database tables 😢 I wouldn't have expected running the specs in docker to wipe out my dynamodb local. I may follow up with another issue and/or pr to avoid wiping out my database when trying to run the specs if I figure out why it happened.
So just hoping travis-ci can run the specs for me for now.