Added more infos to C++ exception reporting #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) to build script parameters to display better C++ exception infos for python
This was referenced Dec 1, 2024
|
This is the issue for this: #85 |
|
Awesome so does this add a new compile time option? Is it enabled by default? Is there any important need to document it ? |
|
AHH no I see -+ it is setting existing options but not adding new ones! |
|
Right now, it is enabled by default here. I don‘t see a reason to not use it. It just delivers more infos. It should not have any performance impacts. |
dancergraham
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I just tested this and I must say, this would have saved me a lot of time with my previous bugfix. :-) The C++ exception looks much better now:
I commented-out my last fix to trigger an exception on purpose in test-runs for this. Especially the context info helps a lot. What do you think?
Best regards,
Christian