Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated demo to use MSAL 3.1.0 #1

Open
MattMinke opened this issue Sep 22, 2023 · 3 comments · May be fixed by #2
Open

Updated demo to use MSAL 3.1.0 #1

MattMinke opened this issue Sep 22, 2023 · 3 comments · May be fixed by #2

Comments

@MattMinke
Copy link

currently the demo is using version 2.30.0. there have been some major changes to the MSAL-browser library in version 3.1.0

@davestewart
Copy link
Owner

davestewart commented Sep 22, 2023

Can you expand on the changes?

Looks like they may be documented here; https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/v2-migration.md

Do you know if it affects the current demo? I no longer use the platform but it would be nice to update the code.

PRs welcome!

@MattMinke
Copy link
Author

Yes sorry. should have included link to migration. I am going to hold off doing any PRs until I hear back about on the bug I filed with them. Possible they have broken the logoutPopup.

AzureAD/microsoft-authentication-library-for-js#6508

@iamexe
Copy link

iamexe commented Sep 25, 2023

Hey, first of all @davestewart thank you so much!
I'm somewhat a beginner and finally managed to implement this in my app.
I added the pull request to add support to 3.1 and fix this issue.

I don't use Typescript so maybe I'll do a PR later to add a 'no-typescript' folder.

Now @MattMinke I have tried with both latest versions of @azure/msal-browser.
I can confirm that before the change it did't work with 3.1 and as you probably observed it did work after:

npm uninstall @azure/msal-browser
npm install @azure/msal-browser@2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants