Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow flexible text length #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow flexible text length #80

wants to merge 1 commit into from

Conversation

ericdum
Copy link

@ericdum ericdum commented Aug 26, 2013

no matter what the text is, do fitText(), it's will fit to 100% width automatticly

@davatron5000
Copy link
Owner

Can you better describe the problem you're trying to fix? Also, we now require educed test cases. It looks like you're just injecting a bunch of CSS that may or may not be necessary.

@ericdum
Copy link
Author

ericdum commented Aug 26, 2013

Please take a look the example.html.

I just added a longer text:

<h1 id="fittext4">Squeeze with FitText For Long String</h1>

And execute following code:

$("#fittext4").fitText();

Before this version, the text will break the line.

This version will automatically fit the width.

Just put it on the browser and check it out.

@dominikwilkowski
Copy link

👍
I was looking for this.
Thanks

@davatron5000
Copy link
Owner

FitText was designed to work with multiple lines of text. So I'm not really sure that this fits that use case. Maybe putting this functionality behind a noBreak: true option is something to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants