Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: skip JS interoperability tests to get branches to build #143

Closed
wants to merge 1 commit into from

tests: skip JS interoperability tests to get branches to build

b276994
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

tests: skip JS interoperability tests to get branches to build #143

tests: skip JS interoperability tests to get branches to build
b276994
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 24, 2024 in 0s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 1567 in src/tree/merkle_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
    --> src/tree/merkle_tree.rs:1567:34
     |
1567 | fn block_node(index: u64, value: &Vec<u8>) -> Node {
     |                                  ^^^^^^^^ help: change this to: `&[u8]`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
     = note: `#[warn(clippy::ptr_arg)]` on by default

Check warning on line 486 in src/tree/merkle_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

if let can be simplified with `.unwrap_or_default()`

warning: if let can be simplified with `.unwrap_or_default()`
   --> src/tree/merkle_tree.rs:482:39
    |
482 |                       additional_nodes: if let Some(additional_upgrade) = p.additional_upgrade {
    |  _______________________________________^
483 | |                         additional_upgrade
484 | |                     } else {
485 | |                         vec![]
486 | |                     },
    | |_____________________^ help: replace it with: `p.additional_upgrade.unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
    = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default