Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more formatting for application data #76

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

Herkarl
Copy link
Member

@Herkarl Herkarl commented Sep 18, 2023

This PR does the following:

  • preserves newlines in the html output in the application page from the users answers (this was the main goal)
  • some additional formatting

it now looks like this:
2023-09-18-14:36:11

text_to_html escapes html input from the string it gets as well, so that shouldn't be a concern

@Herkarl Herkarl changed the title add more formatting for application data fix/add more formatting for application data Sep 18, 2023
@Herkarl
Copy link
Member Author

Herkarl commented Sep 18, 2023

I realise I didn't follow the branching naming convention, sorry

@adriansalamon
Copy link
Member

Thanks! Looks nicer! I am planning to redo this page (this is from last year), but these changes are nice. I left a minor comment, but otherwise looks good!

@Herkarl Herkarl changed the title fix/add more formatting for application data fix: add more formatting for application data Sep 18, 2023
@Herkarl
Copy link
Member Author

Herkarl commented Sep 18, 2023

@adriansalamon updated now! I used <%= if %> instead since <div :if={...}> didn't seem to have an <div :else>

@Herkarl Herkarl temporarily deployed to staging September 18, 2023 14:44 — with GitHub Actions Inactive
@adriansalamon
Copy link
Member

@adriansalamon updated now! I used <%= if %> instead since <div :if={...}> didn't seem to have an <div :else>

You don't need the else statement ;) but that's a very minor nitpick

@adriansalamon adriansalamon merged commit a8d4a2c into main Sep 18, 2023
1 check passed
@adriansalamon
Copy link
Member

❤️ 🦈

@adriansalamon adriansalamon deleted the application-view-formatting branch September 18, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants