Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

80 default out pth argument in transport performanceosmosm utilspy #142

Conversation

r-leyshon
Copy link
Contributor

Description

Fixes #80

Motivation and Context

  • Default path now writes to outputs/osm
  • Refactored test suite to account for this change.
  • Type setting in function signature

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Test configuration details:

  • OS: macos
  • Python version: 3.9.13
  • Java version: openjdk 11.0.19 2023-04-18 LTS
  • Python management system: pip

Advice for reviewer

Checklist:

  • My code follows the intended structure of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional comments

@r-leyshon r-leyshon added the enhancement New feature or request label Sep 20, 2023
@r-leyshon r-leyshon added this to the sprint 4 End milestone Sep 20, 2023
@r-leyshon r-leyshon linked an issue Sep 20, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (93bd867) 96.09% compared to head (7aea45d) 96.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #142   +/-   ##
=======================================
  Coverage   96.09%   96.10%           
=======================================
  Files          11       11           
  Lines         896      898    +2     
=======================================
+ Hits          861      863    +2     
  Misses         35       35           
Flag Coverage Δ
unittests 96.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/transport_performance/osm/osm_utils.py 77.14% <100.00%> (+1.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SergioRec SergioRec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Function filter_osm default folder now creates output file in outputs/osm.
  • Type hinting checked.
  • Tests run as expected. Assertion error when mismatch correct.

@SergioRec SergioRec merged commit 49fd2a9 into dev Sep 28, 2023
11 checks passed
@SergioRec SergioRec deleted the 80-default-out_pth-argument-in-transport_performanceosmosm_utilspy branch September 28, 2023 09:46
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
)

* refactor: Output path & typesetting in func signature

* refactor: Test uses tmpdir, prints on directory creation 49fd2a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OSM x-small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default out_pth argument in transport_performance/osm/osm_utils.py
3 participants