-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tests for invalid data in GTFS dataset #115
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## dev #115 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 11 11
Lines 896 896
=======================================
Hits 782 782
Misses 114 114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CBROWN-ONS please see comments in PR. Happy to have a call if anything is unclear, let me know.
Description
closes #66
This PR provides testing for cases where invalid data has been introduced into the GTFS tables. This includes invalid and non-matching IDs. The tests ensure that these cases are identified and relayed back to the user through
gtfs_kit.feed.validate()
or in this caseGtfsInstance().is_valid()
.Type of change
How Has This Been Tested?
Test configuration details:
Checklist: