Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config class with validation #17

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

ColinDaglish
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 86.25% and project coverage change: +0.56% 🎉

Comparison is base (c4a63a5) 79.82% compared to head (2b35160) 80.38%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/unit_tests      #17      +/-   ##
======================================================
+ Coverage               79.82%   80.38%   +0.56%     
======================================================
  Files                      17       19       +2     
  Lines                     689      719      +30     
======================================================
+ Hits                      550      578      +28     
- Misses                    139      141       +2     
Files Changed Coverage Δ
src/modules/preprocessing.py 91.80% <ø> (-1.54%) ⬇️
src/modules/topic_modelling.py 41.66% <0.00%> (ø)
src/run_pipeline.py 0.00% <0.00%> (ø)
tests/modules/test_preprocessing.py 100.00% <ø> (ø)
src/modules/config.py 92.10% <92.10%> (ø)
tests/modules/test_config.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColinDaglish ColinDaglish merged commit 7339e13 into feature/unit_tests Jul 25, 2023
3 checks passed
@ColinDaglish ColinDaglish deleted the feature/validate-config branch July 25, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant