Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versions for dependencies #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add versions for dependencies #18

wants to merge 1 commit into from

Conversation

DDKatch
Copy link
Contributor

@DDKatch DDKatch commented Nov 9, 2018

related to issue

@DDKatch DDKatch self-assigned this Nov 9, 2018
AleksSenkou
AleksSenkou reviewed Nov 9, 2018
View reviewed changes
Copy link
Contributor

@AleksSenkou AleksSenkou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we use another minor version of rails-veiws for that?

@DDKatch
Copy link
Contributor Author

DDKatch commented Nov 9, 2018

@AleksSenkou for sure, but I've never managed releases on github.

@AleksSenkou
Copy link
Contributor

@DDKatch I see. Let's not do it now in order to finish with rails-views today 😉

@roman-dubrovsky
Copy link
Contributor

@AleksSenkou @DDKatch one more question: what do you think about adding CHANGELOG file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksSenkou AleksSenkou AleksSenkou left review comments

@roman-dubrovsky roman-dubrovsky Awaiting requested review from roman-dubrovsky

@nikitasakau nikitasakau Awaiting requested review from nikitasakau

Assignees

@DDKatch DDKatch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DDKatch @AleksSenkou @roman-dubrovsky