Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stdout-handling #89

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

christian-monch
Copy link
Contributor

@christian-monch christian-monch commented Jan 23, 2025

This PR fixes #82

By default it suppresses all output on stdout that is created when the commands in a template are executed. The output can be written to a file by specifying the -s/--stdout argument in datalad make.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (42537a0) to head (49a3539).

Files with missing lines Patch % Lines
datalad_remake/annexremotes/remake_remote.py 18.75% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   83.08%   90.93%   +7.84%     
==========================================
  Files          29       29              
  Lines        1141     1158      +17     
  Branches      102      105       +3     
==========================================
+ Hits          948     1053     +105     
+ Misses        152       75      -77     
+ Partials       41       30      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christian-monch christian-monch marked this pull request as ready for review January 23, 2025 20:54
@christian-monch christian-monch merged commit 78a827d into datalad:main Jan 23, 2025
6 checks passed
@christian-monch christian-monch deleted the handle-stdout branch January 23, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to remake file if the command writes to stdout (external remote error)
2 participants