rf: use a single patched_env in annex remote
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restricts the use of `patched_env` to the annex remote. The complete "TRANSFER RETRIEVE" implementation is wrapped into a single `patched_env` context. `patched_env` became necessary because datalad's `Dataset.get` will not work properly if the environment variables `GIT_DIR` and `GIT_WORK_TREE` are set.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 91.30% 91.28% -0.03%
==========================================
Files 26 26
Lines 1081 1078 -3
Branches 87 87
==========================================
- Hits 987 984 -3
Misses 65 65
Partials 29 29 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restricts the use of
patched_envto the annex remote. The complete "TRANSFER RETRIEVE" implementation is wrapped into a singlepatched_envcontext.patched_envbecame necessary because datalad'sDataset.getwill not work properly if the environment variablesGIT_DIRandGIT_WORK_TREEare set.