fix: add Windows support and run tests on Windows #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-monch
changed the title
christian-monch
force-pushed
the
windows-support
branch
from
3ccb33d to
869dbd4
Compare
This commit adds code to ensure that method-templates are locally availavle, even if they are annexed.
christian-monch
force-pushed
the
windows-support
branch
from
869dbd4 to
51f0474
Compare
This commit skips tests that generate GPG keys on Windows platforms because GPG2 on Windows does have problems with non-standard `GNUPGHOME` directories, i.e. it cannot start a proper `gpg-agent`. If this problem is fixed, the commit can be reverted.
christian-monch
force-pushed
the
windows-support
branch
3 times, most recently
from
f13149f to
39edb50
Compare
This commit changes the way in which worktrees are generated in Windows. In Windows, every provisioned worktree will have a git config setting that identifies it as a worktree and holds the source of the worktree. Further provision calls, i.e. chained provision calls, in this worktree will use the original source as provision source. In addition they will explicitly enable the datalad remake special remote in the provisioned datasets. This is necessary because `git worktree` does not work together with `git annex` on a crippled file systems, which means it does not work on most Windows systems.
christian-monch
force-pushed
the
windows-support
branch
from
39edb50 to
6e3e59e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 91.28% 91.53% +0.25%
==========================================
Files 26 27 +1
Lines 1078 1110 +32
Branches 87 100 +13
==========================================
+ Hits 984 1016 +32
Misses 65 65
Partials 29 29 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #21
It uses
git cloneinstead ofgit worktreeto create a worktree in a Windows environment.Test use PowerShell commands in a Windows environment.
Trusted execution tests are still not working on Windows due to some
gpg-issue (see issue #87)