fix: use OS-independent PatternPath for items
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a large commit that introduces the type `PatternPath` (an alias of `PurePosixPath`), which is used to address items within a dataset, i.e. subdatasets, directories, and files. This should allow the code to work on platforms with non-Unix path conventions, i.e. Windows.
christian-monch
force-pushed
the
pattern_path
branch
from
9569472 to
e0f97a1
Compare
christian-monch
changed the title
PatternPath for itemsPatternPath for items
This commit robustifies file-URL management to make it work properly in Windows and Posix environments.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 91.60% 91.30% -0.30%
==========================================
Files 25 26 +1
Lines 1060 1081 +21
Branches 87 87
==========================================
+ Hits 971 987 +16
- Misses 63 65 +2
- Partials 26 29 +3 ☔ View full report in Codecov by Sentry. |
christian-monch
changed the title
PatternPath for itemsPatternPath for items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large PR that introduces the type
PatternPath(an alias ofPurePosixPath), which is used to address items within a dataset, i.e. subdatasets, directories, and files.This should allow the code to work uniformly on platforms with non-Unix path conventions, i.e. Windows.