fix: remove modified-detection from provision command #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the dirty check in the provisioning command because `Dataset.status` does not work as expected when executed in the context of a git annex special remote. In this context it might detect a changed subdataset, which should not happen. The reason for this is not clear yet. Once this is resolved, this commit could be reverted.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 92.91% 92.47% -0.44%
==========================================
Files 23 23
Lines 1002 984 -18
Branches 81 79 -2
==========================================
- Hits 931 910 -21
- Misses 50 53 +3
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #69
For unknown reasons,
Dataset.statusdoes not work properly in the context of agit-annex-remake-datalad-remakeprocess if the origin dataset contains subdatasets.