Add insert1_skip_full_duplicates and remove recursive_search
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dimitri Yatsenko <[email protected]>
CBroz1
changed the title
insert1_skip_full_duplicates and recursive_search deprecation warninginsert1_skip_full_duplicates and remove recursive_search
| Args: | ||
| key (str): Key used to search through a nested dictionary | ||
| dictionary (dict): Nested dictionary | ||
| def insert1_skip_full_duplicates(table, entry): |
There was a problem hiding this comment.
Awesome. This will be integrated into DataJoint shortly. datajoint/datajoint-python#1049
dimitri-yatsenko
approved these changes
Dec 1, 2022
|
Hi @dimitri-yatsenko - Is this ready to merge? |
6 tasks
|
We tried this out in practice and ran into issues when the secondary attributes were duplicated with a novel primary key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #42. Stopgap pending feature to datajoint-python (feature request).