Refactor: Replace validation strict parameter with options object #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when we ignore the non alphanumeric characters
Sarrabah
changed the title
pierrecamilleri
requested changes
Jul 9, 2024
Co-authored-by: Pierre Camilleri <[email protected]>
Co-authored-by: Pierre Camilleri <[email protected]>
Co-authored-by: Pierre Camilleri <[email protected]>
Co-authored-by: Pierre Camilleri <[email protected]>
Co-authored-by: Pierre Camilleri <[email protected]>
Sarrabah
force-pushed
the
refactor/validation_strict_parameter
branch
from
138adbb to
4611590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR a pour objectif de remplacer le paramètre "strict" de la fonction "is_valid".
Ce paramètre, en réalité, fait plusieurs choses : il ignore la casse, les accents, et les caractères non alphanumériques etc .
À la place, un nouvel objet de type "Options" sera introduit, permettant de sélectionner ces options de manière plus précise.