-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README and Dockerfile #124
Conversation
1646512
to
8514fc1
Compare
Dockerfile
Outdated
@@ -1,4 +1,4 @@ | |||
FROM openjdk:11-jdk-slim-bullseye | |||
FROM openjdk:21-jdk-slim-bullseye |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use alternative distro other than openjdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the issue with OpenJDK, and do you have a recommendation? I don't usually do a lot of Java development to be honest so I'm not very familiar with the alternatives 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not about the jdk version but more of an issue with dockerfile and docker image
i'd personally use https://hub.docker.com/_/amazoncorretto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you look at https://hub.docker.com/_/openjdk it shows it's deprecated @adamreeve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 makes sense thanks, I wasn't aware it was deprecated. I've changed the base image to be Amazon Corretto now.
This PR includes a few tidy ups and fixes to examples in the README:
ExecutionContexts
that should beSessionContexts
Some of this work is thanks to @pavlovic-ivan and was originally contributed in the G-Research fork