Avoid normalising identifiers #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dietr1ch
force-pushed
the
dev/raw-idents
branch
from
74b339e to
afa8ae8
Compare
The tracked `ahash` no longer builds in nightly as some SIMD features were dropped.
This is awfully surprising to new users, and I think it's a bad thing to do even if people more familiar with SQL DB engines won't be too surprised about it.
Dietr1ch
force-pushed
the
dev/raw-idents
branch
from
afa8ae8 to
8377ee7
Compare
|
This is a breaking change, but given the nature of the tool it's an improvement too, as this normalisation prevents querying non-snake_case tables and fields coming from imported files (csv, parquet, etc...). This is also untested, but I didn't find existing tests to mimic. I did try a local build and runs as expected. I was now able to query sample parquet files for Iris data from https://www.tablab.app/parquet/sample, which is the kind of thing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalising identifiers for column names and tables yields to surprising behaviour (#29, apache/datafusion#13649) and while there's workarounds, it's hard for people that are just trying to start using
bdtto discover them (quoting, renaming their data).I think that a tool shouldn't have surprising behaviour like this.