Amélioration de l'onglet Actions suite aux retours de MerTerre : #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wording - modification du popup de la map sur l'onglet 'ramassages réalisés' - modification des tooltips des graphiques sur l'onglet 'ramassages réalisés' - déplacement dans home.py de la fonction load_df_events_clean() pour charger les evenements à venir - suppression de la police Montserrat - conflit pyproject.toml OK
| # Appel des fonctions pour charger les données | ||
| @st.cache_data | ||
| # Définition d'une fonction pour charger les evenements à venir | ||
| def load_df_events_clean() -> pd.DataFrame: |
There was a problem hiding this comment.
Pourquoi définir une fonction pour charger les données ?
- penser au docstrings pour aider les copains (et l'IDE) à comprendre la fonction ^^
dashboards/app/pages/actions.py
Outdated
There was a problem hiding this comment.
Rien à dire !
Comme pour #29 les html pourraient être dans des fichiers dédiés
dashboards/app/pages/hotspots.py
Outdated
There was a problem hiding this comment.
Ces changements sont-il les même que pour #29 ?
Si oui, c'est OK pour moi
def load_df_events_clean() Chargement des données des événements à venir
Résolution des conflits de merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validé avec Quentin et Téo.