-
Notifications
You must be signed in to change notification settings - Fork 272
closing connection once data diff is executed #785
Conversation
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
fixes issue #784 |
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
All other classes are handled from the |
I am not sure how this will dynamically test for all of the databases. For now, I have written for Postgres (https://github.com/datafold/data-diff/pull/785/files#diff-82fbc96aa3f082d4667c09a2a35aec050c73120de9174e1f37bef26ef9cd3115R173) |
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
@sungchun12 I had to remove connection sharing since it was causing test failure in parallel unit test run |
Signed-off-by: Sarad Mohanan <[email protected]>
Co-authored-by: Sung Won Chung <[email protected]>
Co-authored-by: Sung Won Chung <[email protected]>
Co-authored-by: Sung Won Chung <[email protected]>
Co-authored-by: Sung Won Chung <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
Signed-off-by: Sarad Mohanan <[email protected]>
@sar009 any updates? |
Signed-off-by: Sarad Mohanan <[email protected]>
This PR revamps how we close database connections, adds new unit tests to the main entrypoint logic, and refactors tests for better readability.