Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty lines to avoid triggering unchanged diff detection #3498

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove empty lines to avoid triggering unchanged diff detection #3498

wants to merge 2 commits into from
+75 −1

Conversation

case-k-git
Copy link
Contributor

@case-k-git case-k-git commented Apr 22, 2024 •
edited
Loading

Changes

Remove empty lines to avoid triggering unchanged diff detection. Related to this issue.
#3019

TrimSpace solve the issue but if there are empty new lines inside the SQL each time terraform detect the change. So remove empty lines when checking terraform state diff detection.

Sample

SELECT
  column_a,
  
  column_b
FROM table

Evidence
img

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@case-k-git case-k-git requested review from a team as code owners April 22, 2024 09:28
@case-k-git case-k-git requested review from mgyucht and removed request for a team April 22, 2024 09:28
@case-k-git case-k-git force-pushed the feature/remove-empty-lines-from-heredocs branch from 42ffbf3 to 0f4bd8b Compare April 22, 2024 09:33
@case-k-git case-k-git force-pushed the feature/remove-empty-lines-from-heredocs branch from a6cfbdb to 55d5578 Compare April 22, 2024 13:37
@p-venclovas p-venclovas mentioned this pull request Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht Awaiting requested review from mgyucht mgyucht is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@case-k-git