Add support for tailstrict #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenamar-db
force-pushed
the
tailrec
branch
from
b9b25c8 to
938d7e9
Compare
stephenamar-db
force-pushed
the
tailrec
branch
from
938d7e9 to
4eb8b30
Compare
JoshRosen
reviewed
Jan 8, 2025
JoshRosen
reviewed
Jan 8, 2025
JoshRosen
reviewed
Jan 8, 2025
| case class Apply0(pos: Position, value: Expr, tailstrict: Boolean) extends Expr | ||
| case class Apply1(pos: Position, value: Expr, a1: Expr, tailstrict: Boolean) extends Expr | ||
| case class Apply2(pos: Position, value: Expr, a1: Expr, a2: Expr, tailstrict: Boolean) extends Expr | ||
| case class Apply3(pos: Position, value: Expr, a1: Expr, a2: Expr, a3: Expr, tailstrict: Boolean) extends Expr | ||
| case class ApplyBuiltin(pos: Position, func: Val.Builtin, argExprs: Array[Expr]) extends Expr { |
There was a problem hiding this comment.
I'm curious about the interaction between tail strict mode, built-in function application, and potential lazy evaluation in built-ins.
For example, it is possible to have a tailstrict user-defined function which invokes a built-in function which returns lazy values which in turn reference user defined functions that could potentially be affected by tail strict mode? i.e. do we need "memory" of whether tail strict mode was in effect at the time of creation of a lazy value?
There was a problem hiding this comment.
Maybe? I'm not sure to be honest. I'm trying to find an example where this would cause an issue.
As far as I can see, arguments to builtins are always forced (see Builtin classes in Val)
JoshRosen
reviewed
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I'm implementing tailstrict in sjsonnet.
I'm following the guidance from google/jsonnet#343 (comment):
Quote:
Resolves #189.