fix windows path (#660)

Makefile

@@ -1,6 +1,10 @@
 dev:
 	python3 -m venv .venv
+ifeq ($(OS), Windows_NT)
+	.venv\Scripts\activate
+else
 	. .venv/bin/activate
+endif
 	pip install '.[dev]'
 
 install:

databricks/sdk/mixins/files.py

@@ -3,6 +3,7 @@
 import base64
 import os
 import pathlib
+import platform
 import shutil
 import sys
 from abc import ABC, abstractmethod
@@ -266,8 +267,9 @@ def __repr__(self) -> str:
 
 class _Path(ABC):
 
-    def __init__(self, path: str):
-        self._path = pathlib.Path(str(path).replace('dbfs:', '').replace('file:', ''))
+    @abstractmethod
+    def __init__(self):
+        ...
 
     @property
     def is_local(self) -> bool:
@@ -327,6 +329,12 @@ def as_string(self) -> str:
 
 class _LocalPath(_Path):
 
+    def __init__(self, path: str):
+        if platform.system() == "Windows":
+            self._path = pathlib.Path(str(path).replace('file:///', '').replace('file:', ''))
+        else:
+            self._path = pathlib.Path(str(path).replace('file:', ''))
+
     def _is_local(self) -> bool:
         return True
 
@@ -393,7 +401,7 @@ def __repr__(self) -> str:
 class _VolumesPath(_Path):
 
     def __init__(self, api: files.FilesAPI, src: Union[str, pathlib.Path]):
-        super().__init__(src)
+        self._path = pathlib.PurePosixPath(str(src).replace('dbfs:', '').replace('file:', ''))
         self._api = api
 
     def _is_local(self) -> bool:
@@ -462,7 +470,7 @@ def __repr__(self) -> str:
 class _DbfsPath(_Path):
 
     def __init__(self, api: files.DbfsAPI, src: str):
-        super().__init__(src)
+        self._path = pathlib.PurePosixPath(str(src).replace('dbfs:', '').replace('file:', ''))
         self._api = api
 
     def _is_local(self) -> bool:

tests/test_dbfs_mixins.py

@@ -70,3 +70,33 @@ def test_fs_path_invalid(config):
     with pytest.raises(ValueError) as e:
         dbfs_ext._path('s3://path/to/file')
     assert 'unsupported scheme "s3"' in str(e.value)
+
+
+def test_dbfs_local_path_mkdir(config, tmp_path):
+    from databricks.sdk import WorkspaceClient
+
+    w = WorkspaceClient(config=config)
+    w.dbfs._path(f'file:{tmp_path}/test_dir').mkdir()
+    assert w.dbfs.exists(f'file:{tmp_path}/test_dir')
+
+
+def test_dbfs_exists(config, mocker):
+    from databricks.sdk import WorkspaceClient
+
+    get_status = mocker.patch('databricks.sdk.service.files.DbfsAPI.get_status', side_effect=NotFound())
+
+    client = WorkspaceClient(config=config)
+    client.dbfs.exists('/abc/def/ghi')
+
+    get_status.assert_called_with('/abc/def/ghi')
+
+
+def test_volume_exists(config, mocker):
+    from databricks.sdk import WorkspaceClient
+
+    get_metadata = mocker.patch('databricks.sdk.service.files.FilesAPI.get_metadata')
+
+    client = WorkspaceClient(config=config)
+    client.dbfs.exists('/Volumes/abc/def/ghi')
+
+    get_metadata.assert_called_with('/Volumes/abc/def/ghi')