Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Detailed message for using source-linked deployment with file_path specified #2119

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

ilyakuz-db
Copy link
Contributor

@ilyakuz-db ilyakuz-db commented Jan 10, 2025

Changes

Resolves remaining comments from here #2046

This and this are on hold until Pieter's response

Tests

@ilyakuz-db ilyakuz-db changed the title fix: Additional comments for source-linked deployment fix: Detailed message for using source-linked deployment with file_path specified Jan 20, 2025
@ilyakuz-db ilyakuz-db added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 84a7305 Jan 20, 2025
9 checks passed
@ilyakuz-db ilyakuz-db deleted the fix/source-linked-file-path-fixes branch January 20, 2025 16:21
andrewnester added a commit that referenced this pull request Jan 23, 2025
CLI:
 * Added text output templates for apps list and list-deployments ([#2175](#2175)).
 * Fix duplicate "apps" entry in help output ([#2191](#2191)).

Bundles:
 * Allow yaml-anchors in schema ([#2200](#2200)).
 * Show an error when non-yaml files used in include section ([#2201](#2201)).
 * Set WorktreeRoot to sync root outside git repo ([#2197](#2197)).
 * fix: Detailed message for using source-linked deployment with file_path specified ([#2119](#2119)).
 * Allow using variables in enum fields ([#2199](#2199)).
 * Add experimental-jobs-as-code template ([#2177](#2177)).
 * Reading variables from file ([#2171](#2171)).
 * Fixed an apps message order and added output test ([#2174](#2174)).
 * Default to forward slash-separated paths for path translation ([#2145](#2145)).
 * Include a materialized copy of built-in templates ([#2146](#2146)).
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
CLI:
* Added text output templates for apps list and list-deployments
([#2175](#2175)).
* Fix duplicate "apps" entry in help output
([#2191](#2191)).

Bundles:
* Allow yaml-anchors in schema
([#2200](#2200)).
* Show an error when non-yaml files used in include section
([#2201](#2201)).
* Set WorktreeRoot to sync root outside git repo
([#2197](#2197)).
* fix: Detailed message for using source-linked deployment with
file_path specified
([#2119](#2119)).
* Allow using variables in enum fields
([#2199](#2199)).
* Add experimental-jobs-as-code template
([#2177](#2177)).
* Reading variables from file
([#2171](#2171)).
* Fixed an apps message order and added output test
([#2174](#2174)).
* Default to forward slash-separated paths for path translation
([#2145](#2145)).
* Include a materialized copy of built-in templates
([#2146](#2146)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants