Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test about using variable in bundle.git.branch #2118

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add test about using variable in bundle.git.branch #2118

wants to merge 4 commits into from
+158 −6

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 10, 2025 •
edited
Loading

This test checks load git details functionality + variable interpolation there.

The variables are not working there because LoadGitDetails mutator is running before variable interpolation.

This also includes a couple fixes for acceptance tests on Windows:

  • Correctly replace tmp path that is used for DATABRICKS_TF_EXEC_PATH
  • Pass -buildvcs=false to go build. It's not needed on CI but it is needed on my local windows VM.

@denik denik temporarily deployed to test-trigger-is January 10, 2025 11:05 — with GitHub Actions Inactive
@denik denik marked this pull request as draft January 10, 2025 13:12
@denik denik temporarily deployed to test-trigger-is January 10, 2025 13:18 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is January 10, 2025 13:21 — with GitHub Actions Inactive
@denik
fixes for Windows:
97f9bfb 
 - setting DATABRICKS_TF_EXEC_PATH to /tmp/ on Windows
 - disable crlf conversion in git
@denik denik temporarily deployed to test-trigger-is January 13, 2025 10:45 — with GitHub Actions Inactive
@denik denik marked this pull request as ready for review January 13, 2025 10:51
denik
denik commented Jan 13, 2025
View reviewed changes
acceptance/script.prepare

git-repo-init() {
git init -qb main
git config --global core.autocrlf false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pietern Found out about this option because a warning was printed by git about this and was captured in test output. This must be the reason we need to fix crlf in golden files in integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern Awaiting requested review from pietern pietern is a code owner

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@denik