feat(query): support extract EPOCH from timestamp #17385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
TCeason
force-pushed
the
fix_17384
branch
2 times, most recently
from
150b124 to
b23dd38
Compare
sundy-li
reviewed
Jan 29, 2025
| registry.register_passthrough_nullable_1_arg::<TimestampType, Float64Type, _, _>( | ||
| "epoch_microsecond", | ||
| |_, _| FunctionDomain::Full, | ||
| vectorize_1_arg::<TimestampType, Float64Type>(|val, ctx| { |
There was a problem hiding this comment.
why not return the val directly?
There was a problem hiding this comment.
Maybe we also need to respect the timezone?
There was a problem hiding this comment.
the epoch number will be consistent in all timezones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is