Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace risky dma_buffer_as_vec implementations #16829

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Nov 13, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Fix incorrect cap,
Modify the implementation to match the Allocator api

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: coldWater <[email protected]>
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 13, 2024
@forsaken628 forsaken628 marked this pull request as ready for review November 13, 2024 06:06
Signed-off-by: coldWater <[email protected]>
Signed-off-by: coldWater <[email protected]>
@BohuTANG BohuTANG merged commit ceb2d03 into databendlabs:main Nov 15, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants