Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tweak batch deletion concurrency #16770

Merged
merged 2 commits into from
Nov 5, 2024
Merged

chore: tweak batch deletion concurrency #16770

merged 2 commits into from
Nov 5, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Nov 5, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The default concurrency for batch file deletion during orphan data cleanup was set too high. To mitigate the 503 errors, the default concurrency limit has been adjusted to a maximum of 3. (follow the practice of #16312)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - tweak default settings

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): tweak default settings

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 5, 2024
@dantengsky dantengsky marked this pull request as ready for review November 5, 2024 05:03
@dantengsky dantengsky added this pull request to the merge queue Nov 5, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 5, 2024
@BohuTANG BohuTANG merged commit d2e4dca into databendlabs:main Nov 5, 2024
74 checks passed
dantengsky added a commit to dantengsky/fuse-query that referenced this pull request Nov 5, 2024
@dantengsky
chore: tweak batch deletion concurrency (databendlabs#16770)
a8fa8f0 
* chore: tweak batch deletion concurrency

* chore: tweak remove file in batch thread pool size
@dantengsky dantengsky mentioned this pull request Nov 5, 2024
Merged
11 tasks
dantengsky added a commit that referenced this pull request Nov 5, 2024
@dantengsky
chore: (backport to 636-rc3) tweak batch deletion concurrency (#16770) (
bdd6d9e 
#16772)

chore: tweak batch deletion concurrency (#16770)

* chore: tweak batch deletion concurrency

* chore: tweak remove file in batch thread pool size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkyFan2002 SkyFan2002 SkyFan2002 approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantengsky @SkyFan2002 @BohuTANG