Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove location_prefix, which is no longer supported #16757

Merged
merged 4 commits into from
Nov 5, 2024
Merged

refactor: remove location_prefix, which is no longer supported #16757

merged 4 commits into from
Nov 5, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Nov 4, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

remove location_prefix, no longer supported.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 4, 2024
@dantengsky dantengsky marked this pull request as ready for review November 4, 2024 10:07
@dantengsky
Copy link
Member Author

@BohuTANG PTAL , the corresponding issue is : #16755

@BohuTANG BohuTANG merged commit b89a604 into databendlabs:main Nov 5, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkyFan2002 SkyFan2002 SkyFan2002 approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: consider removing part_prefix from fuse table location
3 participants
@dantengsky @SkyFan2002 @BohuTANG