-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refine vacuum (backport PR #16743 to release/v1.2.636-rc3) #16744
Merged
dantengsky
merged 6 commits into
databendlabs:release/v1.2.636-rc3
from
dantengsky:release/v1.2.636-rc3-vacuum-orphan
Nov 1, 2024
Merged
chore: refine vacuum (backport PR #16743 to release/v1.2.636-rc3) #16744
dantengsky
merged 6 commits into
databendlabs:release/v1.2.636-rc3
from
dantengsky:release/v1.2.636-rc3-vacuum-orphan
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
this PR only has small changes that no need to record, like coding styles.
label
Oct 31, 2024
dantengsky
changed the title
chore: refine vacuum
chore: refine vacuum (backport PR #16743 to release/v1.2.636-rc3)
Oct 31, 2024
If only orphans left, the vacuum should works as expected.
dantengsky
force-pushed
the
release/v1.2.636-rc3-vacuum-orphan
branch
from
October 31, 2024 14:17
5d24019
to
a616def
Compare
dantengsky
force-pushed
the
release/v1.2.636-rc3-vacuum-orphan
branch
from
October 31, 2024 15:44
f66edb0
to
3e066ad
Compare
SkyFan2002
approved these changes
Nov 1, 2024
Avoid bendsql version issues
dantengsky
force-pushed
the
release/v1.2.636-rc3-vacuum-orphan
branch
from
November 1, 2024 04:03
0c15c52
to
e5a2bfa
Compare
TCeason
reviewed
Nov 1, 2024
@TCeason PTAL : logic test |
TCeason
approved these changes
Nov 1, 2024
TCeason
approved these changes
Nov 1, 2024
Alter user's modify is LGTM |
dantengsky
merged commit Nov 1, 2024
2dc25fb
into
databendlabs:release/v1.2.636-rc3
73 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
backport PR #16743 to release/v1.2.636-rc3.
If only orphans left, the vacuum should continue working as expected (purge all the orphans).
Instead of using prefix extracted from the "path" of object belong to the GC root, using block/bloom_filter_index/segment prefix directly.
Different from PR #16743 (which is being merged into main branch):
the block name is (kept as) prefixed with 'g' in this PR, as PR fix: add compatibility for reading non-standard decimal256 format #16585 has not been merged into main yet (or will not be).
https://github.com/databendlabs/databend/pull/16744/files#diff-9d4aa60a0f7398a38f14b3c0ba1009a992cd2cd5b65f1e00642f5f1ba5d430d8R109
related unit test has been tweaked accordingly.
Tests
Type of change
This change is