Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine vacuum (backport PR #16743 to release/v1.2.636-rc3) #16744

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Oct 31, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

backport PR #16743 to release/v1.2.636-rc3.

If only orphans left, the vacuum should continue working as expected (purge all the orphans).

Instead of using prefix extracted from the "path" of object belong to the GC root, using block/bloom_filter_index/segment prefix directly.

Different from PR #16743 (which is being merged into main branch):

  1. the block name is (kept as) prefixed with 'g' in this PR, as PR fix: add compatibility for reading non-standard decimal256 format #16585 has not been merged into main yet (or will not be).

    https://github.com/databendlabs/databend/pull/16744/files#diff-9d4aa60a0f7398a38f14b3c0ba1009a992cd2cd5b65f1e00642f5f1ba5d430d8R109

related unit test has been tweaked accordingly.

  1. Logic test "tests/suites/0_stateless/18_rbac/18_0011_alter_own_username" also tweaked to align with the main branch

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 31, 2024
@dantengsky dantengsky changed the title chore: refine vacuum chore: refine vacuum (backport PR #16743 to release/v1.2.636-rc3) Oct 31, 2024
If only orphans left, the vacuum should works as expected.
@dantengsky dantengsky force-pushed the release/v1.2.636-rc3-vacuum-orphan branch from 5d24019 to a616def Compare October 31, 2024 14:17
@dantengsky dantengsky force-pushed the release/v1.2.636-rc3-vacuum-orphan branch from f66edb0 to 3e066ad Compare October 31, 2024 15:44
@dantengsky dantengsky marked this pull request as ready for review November 1, 2024 02:38
@dantengsky dantengsky force-pushed the release/v1.2.636-rc3-vacuum-orphan branch from 0c15c52 to e5a2bfa Compare November 1, 2024 04:03
@dantengsky
Copy link
Member Author

@TCeason PTAL :

logic test tests/suites/0_stateless/18_rbac/18_0011_alter_own_username has been updated to align with the version in the main branch.

@TCeason
Copy link
Collaborator

TCeason commented Nov 1, 2024

Alter user's modify is LGTM

@dantengsky dantengsky merged commit 2dc25fb into databendlabs:release/v1.2.636-rc3 Nov 1, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants