-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HTTP handler use cookie to pass session id to and from clients. #16735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Oct 30, 2024
7 tasks
everpcpc
approved these changes
Oct 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
/v1/session/heartbeat
,/v1/session/refresh
now only used for refreshing session tokenneed_refresh
toneed_keep_alive
: client need to logout and heartbeat (if need to be idle for more than 4 hours) when it is true.disable_session_token
drop_client_session_state
after this pr, we can first add cookie support and logout to clients to make temp table availble
Tests
Type of change
This change is