Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add timeout for detect_region operation to prevent hanging request #16709

Merged

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Oct 28, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Ensures that the ·detect_region· operation will time out if it cannot be fulfilled within 10 seconds.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - add timeout protection

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 28, 2024
@dantengsky dantengsky force-pushed the chore-add_detect_region_timeout branch from 8197ea9 to 905d23f Compare October 28, 2024 13:04
@dantengsky dantengsky marked this pull request as ready for review October 28, 2024 13:57
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dantengsky for helping implementing this!

@dantengsky dantengsky added this pull request to the merge queue Oct 28, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 28, 2024
…equest (#16709)

chore: add timeout for `detect_region` operation to prevent hanging requests
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2024
@dantengsky dantengsky added this pull request to the merge queue Oct 28, 2024
Merged via the queue into databendlabs:main with commit a2b8adc Oct 28, 2024
75 checks passed
@dantengsky dantengsky deleted the chore-add_detect_region_timeout branch October 28, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants