-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(base): add stacktrace to replace backtrace #16643
refactor(base): add stacktrace to replace backtrace #16643
Conversation
binary size:
default:
remove debug file
use addr2line to parse address
restore debug file
|
# Conflicts: # Cargo.lock
# Conflicts: # src/common/exception/tests/it/exception_flight.rs
# Conflicts: # Cargo.lock
aarch64-unknown-linux-gnu and x86_64-unknown-linux-musl test passed. |
@zhang2014 Good job! Will you consider to publish it as a crate? |
It‘s only rewritten for ELF, so I think it may not be able to handle all scenarios. |
A crate doesn't need to handle all scenarios. It's quite useful even if it’s only rewritten for ELF. I encourage publishing a crate for us, which may attract other contributors and make it much easier to test and reuse. |
…tafuse into refactor/optimize_backtrace
…tafuse into refactor/optimize_backtrace
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor(base): add stacktrace to replace backtrace
Tests
Type of change
This change is