Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add unload options overwrite, include_query_id and use_raw_path. #16614

Merged
merged 4 commits into from
Oct 16, 2024
Merged

feat: add unload options overwrite, include_query_id and use_raw_path. #16614

merged 4 commits into from
Oct 16, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Oct 15, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 15, 2024
@youngsofun youngsofun mentioned this pull request Oct 15, 2024
Open
@youngsofun youngsofun changed the title feat: add unload options include_query_id and use_raw_path. feat: add unload options include_query_id and use_raw_path. Oct 15, 2024
@youngsofun youngsofun changed the title feat: add unload options include_query_id and use_raw_path. feat: add unload options overwrite, include_query_id and use_raw_path. Oct 16, 2024
Xuanwo
Xuanwo reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

src/query/ast/src/ast/statements/copy.rs Outdated Show resolved Hide resolved
@sundy-li sundy-li added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@youngsofun youngsofun added this pull request to the merge queue Oct 16, 2024
Merged via the queue into databendlabs:main with commit a37384b Oct 16, 2024
72 checks passed
@youngsofun youngsofun deleted the unload branch October 16, 2024 20:35
@BohuTANG
Copy link
Member

@soyeric128 Need doc, thanks.

@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: copy into location support option 'overwrite=true'
4 participants
@youngsofun @BohuTANG @sundy-li @Xuanwo