Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): ntile frame should be unbounded #16604

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Oct 14, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

ntile frame should be unbounded

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 14, 2024
Copy link

what-the-diff bot commented Oct 14, 2024

PR Summary

  • Simplified Function Call
    The code calling the function resolve_window_frame has been cleaned up. A parameter that was previously required (partitions) is no longer needed, making the function easier to use.

  • Streamlined Window Function Frame Creation
    The code that creates a thing called a "Window Function Frame" has been streamlined. Specifically, it's about a type of Window Function Frame known as Ntile. The process was previously filled with unnecessary checks related to partition_by which have now been gotten rid of. This results in more efficient code.

  • Improved Test Scenarios
    The testing for this process, file named window_ntile.test, has been enhanced. More scenarios including multiple data insertions and using the ntile function in queries have been added. These more in-depth tests will help ensure the code works as expected.

@BohuTANG BohuTANG merged commit 42bca6b into databendlabs:main Oct 14, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ntile frame not correct
3 participants